2.x: coverage and cleanup 10/12-1#4696
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Oct 12, 2016
Merged
Conversation
Current coverage is 83.86% (diff: 97.46%)@@ 2.x #4696 diff @@
==========================================
Files 567 567
Lines 37618 37651 +33
Methods 0 0
Messages 0 0
Branches 5790 5795 +5
==========================================
+ Hits 31393 31577 +184
+ Misses 4233 4116 -117
+ Partials 1992 1958 -34
|
Collaborator
|
@akarnokd you missed the wrong CompositeException constructor call in |
JakeWharton
approved these changes
Oct 12, 2016
Member
Author
|
@vanniktech yeah. Would you like to do a PR? |
Collaborator
|
I'll include that in one that I was planning to push out anyways today which is a big bigger. ~60 files |
Member
Author
|
What are you changing in 60 files? |
Collaborator
|
Null cleanups |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CompletableoperatorsCompletablePeek